[2019.03] Some fixes for MySQL8 and PHP7.3 #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes mysql PASSWORD usage away from the initial always used sql for looking for mathcing users. The deprecated Mysql password hash type will still work, just less efficient. But as PASSWORD() sql function is removed in Mysql8 it won't work there.
glye
requested changes
May 3, 2019
There was a problem hiding this comment.
It still uses PASSWORD() a little further down: c2500f7#diff-9aabf5ca51952bbd469991c839db4f3eR889
So if you use hash type 4 and upgrade to mysql 8, it will fail afaik.
|
yes, but it at least won't fail for any other hash type like it did before this change EDIT: Tried to make this more clear in 2ef72e0 |
glye
approved these changes
May 3, 2019
emodric
approved these changes
May 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not imply full MYSQL8 support, but at least it makes it possible to login.