Popup for the custom tag sub/sup fixed #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Jun 5, 2019
Co-Authored-By: André R. <andre.romcke@gmail.com>
|
@pkamps Do you need this on previous versions also (not just 2019.03) ? If so are you able to rebase this? |
|
Not needed in any particular version. Just sharing my effort on the legacy code. |
andrerom
pushed a commit
that referenced
this pull request
Aug 9, 2019
* Popup for the custom tag sub/sup fixed * Update extension/ezoe/design/standard/templates/ezoe/tag_custom.tpl Co-Authored-By: André R. <andre.romcke@gmail.com> (cherry picked from commit fb58e79)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sub (subscript) and sup (superscript) tags work, but there is a UI issue.
Hitting "Ok" once adds the tag, but does not close the dialog. The dialog only closes upon clicking "Cancel."
While the dialog is open, each click of "Ok" after the first inserts the highlighted text at the beginning of the paragraph, in the sub or sup style.
Hitting "Cancel" is the only way out, which makes the necessary workflow:
Select text
Select Custom tags
Select "Sup"
Click OK
Click Cancel
Reproduce / Testing instructions
Select text
Select Custom tags
Select "Sup"
Click OK => Dialog remains open
Click OL => Duplicate text inserted at beginning of paragraph.
Tested with: Mac Chrome.