Fix EZP-30718: Allow RerunURL to be used on hidden pages #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterkeung
force-pushed
the
rerunurl_hidden_pages
branch
from
47473d4
to
cbf82b3
Compare
andrerom
reviewed
Jul 4, 2019
andrerom
suggested changes
Jul 8, 2019
peterkeung
force-pushed
the
rerunurl_hidden_pages
branch
from
cbf82b3
to
0285e78
Compare
andrerom
approved these changes
Jul 9, 2019
glye
approved these changes
Jul 9, 2019
andrerom
pushed a commit
that referenced
this pull request
Aug 9, 2019
(cherry picked from commit a8d24e4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.ez.no/browse/EZP-30718
The Rerun URL instructions get trapped in the view cache (for hidden pages) because the redundant check for the module exit status can never pass once a page is cached.
The check against "rerun_uri" in the module parameters is sufficient.