EZP-30782: allow sorting by trashed field #1440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Aug 9, 2019
konradoboza
approved these changes
Aug 9, 2019
mateuszbieniek
approved these changes
Aug 9, 2019
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
This is a continuation of the work done in here: #1439
I created a new PR because @andrerom asked me to rebase 2019.03 branch but I was having issues. The rebase was complaining about the composer.json. The conflict was easy to fix but some some reason when I was
git rebase --continuegit was stuck unable to finish the rebase so I created this new branch of 2019.03.I've also added a new commit with the unit test as requested.
Jira ticket: https://jira.ez.no/browse/EZP-30782
Thanks!