Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for deleting packages. #296

Merged
merged 2 commits into from Mar 1, 2012
Merged

Conversation

HenrikWM
Copy link

Added support for deleting packages via CLI / PHP with ezpm.php.

@andrerom
Copy link
Contributor

Cool, would almost think you had worked on this part before :)

if ( $package )
{
$package->remove();
$cli->error( "Package " . $commandItem['name'] . " deleted." );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this use $cli->output?

@andrerom
Copy link
Contributor

Thanks, have you signed a cla btw? Could not find one from you or your company.
ref: http://share.ez.no/community-project/contributor-licensing-agreement-cla

@HenrikWM
Copy link
Author

I will mostly contribute small bugfixes and minor improvements when I can, and according to the CLA-page as long as I just contribute minor fixes we don't need to sign it. Correct?

I've sent a signed CLA anyways though :)

@andrerom
Copy link
Contributor

according to the CLA-page as long as I just contribute minor fixes we don't need to sign it. Correct?

Yes, but the line between what size is small enough to avoid having to do a CLA has always been a bit blurry to me :)
@nfrp Do you happen to know any rule of thumb on this?

I've sent a signed CLA anyways though :)

Thanks :)

@nfrp
Copy link
Contributor

nfrp commented Feb 29, 2012

Thanks @HenrikWM, CLA properly received. I will send it back to you, signed-back.
General rule : CLAs preferred, for any contribution.

Thanks again for your contribution, and the future ones : keep them coming ! :)

andrerom added a commit that referenced this pull request Mar 1, 2012
Added support for deleting packages.
@andrerom andrerom merged commit c4cdf9a into ezsystems:master Mar 1, 2012
@andrerom
Copy link
Contributor

andrerom commented Mar 1, 2012

Merged, thanks Henrik!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants