New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for deleting packages. #296
Conversation
Cool, would almost think you had worked on this part before :) |
if ( $package ) | ||
{ | ||
$package->remove(); | ||
$cli->error( "Package " . $commandItem['name'] . " deleted." ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this use $cli->output?
Thanks, have you signed a cla btw? Could not find one from you or your company. |
I will mostly contribute small bugfixes and minor improvements when I can, and according to the CLA-page as long as I just contribute minor fixes we don't need to sign it. Correct? I've sent a signed CLA anyways though :) |
Yes, but the line between what size is small enough to avoid having to do a CLA has always been a bit blurry to me :)
Thanks :) |
Thanks @HenrikWM, CLA properly received. I will send it back to you, signed-back. Thanks again for your contribution, and the future ones : keep them coming ! :) |
Added support for deleting packages.
Merged, thanks Henrik! |
Added support for deleting packages via CLI / PHP with ezpm.php.