Fix for EZP-20741: Allow default content disposition to be overridden #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
+1 |
|
Just had another client need something similar. Any barriers to getting this merged? |
|
review ping @patrickallaert / @yannickroger |
|
+1 |
1 similar comment
|
+1 |
andrerom
added a commit
that referenced
this pull request
Sep 24, 2013
Fix for EZP-20741: Allow default content disposition to be overridden
|
Merged, thanks @peterkeung! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have clients who want to set the default content disposition to "inline" for all MIME types. This is hard-coded to "attachment" and you have to set the content disposition to "inline" for each MIME type – this is difficult because you have to build a list of every MIME type and maintain this list for future MIME types.
If you are able to set the default content disposition for all MIME types to be "inline" then you can essentially defer to browser behavior: if it can open a document inline, then it does. Otherwise, it falls back to "attachment" anyway.