EZP-20957: Removed misplaced semicolon which breaks the flow

[jeromegamez]

The semicolon causes the method to always return true at this place.

if ( isset( $row[0] ) and $row[0] == $generatingFileMtime );
{
    return true;
}

See https://jira.ez.no/browse/EZP-20957

[gggeek]

well spotted!!!

[andrerom]

This should be reported as issue, might be it is causing issues that just haven't been reported..

[jeromegamez]

I have created a JIRA issue and updated the name of the pull request.

[andrerom]

+1

[crevillo]

Btw, we can change that and for && (CS)

[tharkun]

Nice

+1

[yannickroger]

+1

[bdunogier]

Good catch, +1. But we indeed need an issue for it.

[jeromegamez]

@bdunogier The issue is here https://jira.ez.no/browse/EZP-20957 - or do you mean a real world issue that is caused by the misplaced semicolon?

[yannickroger]

Thanks for the PR.
I rebased it in a single commit and merged it in master : dca49de

[peterkeung]

What is the problem / test case here? Is it that in some situations the "generating" file is prematurely considered timed out? Context for my questions: we occasionally experience odd issues with the cluster and would love to know whether our problem cases match the identified problem cases. That way we can know which patches to apply.

[jeromegamez]

@peterkeung I have no actual test case for this, but I think your assumption is correct.