Fix ezp-21046: view cache is not expiring in one node #665
Conversation
| @@ -85,6 +85,7 @@ public function copyFromDFS( $srcFilePath, $dstFilePath = false ) | |||
| $ret = $this->createFile( $dstFilePath, file_get_contents( $srcFilePath ) ); | |||
| } | |||
|
|
|||
| $ret = $this->copyTimestamp( $srcFilePath, $dstFilePath ); | |||
There was a problem hiding this comment.
If the file is not created correctly, perhaps this should not be executed?
Suggestion: add an if ( $ret ) condition before this line
|
I'd rather agree with @gggeek here. Syncing the timestamps would indeed most likely fix the issue, but we are fixing the symptoms, not the illness. No cache file should be used without checking their validity on the database, as simple as that. It seems that this is the case, since this cache is most likely not valid anymore, right ? |
|
https://jira.ez.no/browse/EZP-21046#comment-78484 After looking into the code and trying different fixes for it ( adding extra db checks fixes the problem too), I think this solution is the most reliable one with less side effects on this very critical piece of code. So +1 |
|
+1 following our numerous discussions on the topic. Semantically, it makes sense do this sync anyway. |
|
Merged in master : 512174a |
No description provided.