Fix EZP-22628: Children containing ezuser can not be trashed #936
Conversation
|
+1 |
1 similar comment
|
+1 |
|
In your opinion what should be done regarding translation, especially if this fix is backported ? |
|
I'd have phrased a bit differently: "Objects containing ezuser attributes can not be sent to trash". And technically, it doesn't apply to "objects containing ezuser attributes", but to User objects... since they have to be declared as such in the settings. "User objects can't be sent to trash" would do. |
| <input type="checkbox" name="MoveToTrash" value="1" | ||
| {if and($move_to_trash, $move_to_trash_allowed) }checked="checked" {/if} | ||
| {if not($move_to_trash_allowed)}disabled="disabled" {/if} | ||
| title="{'If "Move to trash" is checked, the items will be moved to the trash instead of being permanently deleted.'|i18n( 'design/admin/node/removeobject' )|wash}" |
There was a problem hiding this comment.
If "Move to trash" is checked, the items will be moved to the trash instead of being permanently deleted.
"If checked, items will be moved to trash instead of being permanently deleted." ? (shorter)
There was a problem hiding this comment.
This one is the original text so I did not change it.
|
+1 |
|
Thanks for the feedback @bdunogier it has been taking care of. |
|
Also take note of the related PR #939 |
Fix EZP-22628: Children containing ezuser can not be trashed
Link: https://jira.ez.no/browse/EZP-22628
Description
Object containing ezuser attribute can not be sent to trash. It has been the case for a while (and for 10 years for the user class).
If you delete the parent of one of these object (and the parent don't have an ezuser field) ezpublish will try to send it to trash and this will trigger side effects. A quick example is to delete a user_group containing users.
This patch modifies slightly the behavior:
Screenshot
Tests
Manual sanity check on content deletion.
TODO