Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Min password length #13

Closed
wants to merge 2 commits into from
Closed

Min password length #13

wants to merge 2 commits into from

Conversation

crevillo
Copy link
Contributor

found same check in another file

@andrerom
Copy link
Contributor

Applied, thanks.
But do note that hasVariable is just a isset call, so the only benefit you get here is shorter lines of code and dependency on config file values. Just saying in case you just declared war on hasVariable use :)

@crevillo
Copy link
Contributor Author

i see.
Changed the doc of validatePassword function also... this pull request is enough or something more is needed?

@andrerom
Copy link
Contributor

I pulled it in via Fork Queue, so for things like that you can skip pull requests if you want and just notify us somehow from time to time if you have a bunch of such changes (doc changes), up to you.
Note for next time: @static is not needed anymore if function is declared as static (same goes for @access I think when it comes to visibility).

@crevillo
Copy link
Contributor Author

ok. thanks for the tips André!.

andrerom added a commit that referenced this pull request Sep 19, 2012
@andrerom
Merge pull request #13 from dpobel/issue_18209
9cb7c4a 
Fixed #18209: Usability issue with OE and literal
andrerom added a commit that referenced this pull request Sep 19, 2012
@andrerom
Merge pull request #13 from jdespatis/fix-18317
476af4d 
Fixed #018317: ezjscore no more drops abusively js code when minifying on specific case
peterkeung pushed a commit to peterkeung/ezpublish that referenced this pull request Sep 29, 2017
@pkamps
Merge pull request ezsystems#13 from mugoweb/EZP-25771
817643e 
Verify existence of constructor in eZExtension->getHandler()
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crevillo @andrerom