Issue 019242 #306
Merged
Issue 019242 #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $handlerFile = 'kernel/classes/ssohandlers/ez' . strtolower( $ssoHandler ) . 'ssohandler.php'; | ||
| if ( file_exists( $handlerFile ) ) | ||
| $className = 'eZ' . $ssoHandler . 'SSOHandler'; | ||
| if( class_exists( $className ) ) |
There was a problem hiding this comment.
This will make use of autoload mechanism. Much more efficient than the plain old include_once() calls
|
Thanks Carlos for this one ! |
|
yw. no problem with the delay. this can wait. i'll back here in case you forgot it :) |
|
Yes please :) |
|
This sounds all good to me @crevillo |
|
glad it helped!. cheers. |
|
Thanks guys, rock'n roll ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi. even my branch has be created for issue 19242, there a commit for issue 19243 too.