Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1341: Fixed inject valid CredentialsResolver #88

Merged
merged 2 commits into from
Oct 29, 2021

Conversation

ciastektk
Copy link
Contributor

@ciastektk ciastektk commented Oct 28, 2021

Question Answer
JIRA issue IBX-1341
Type bug
Target Ibexa DXP version v3.3.11
BC breaks no
Doc needed no

Wrong CredentialsResolver is inject to ConfigurableExportParametersFactory so when trying to run export command with simple option contentTypeIdList following exception is thrown:

In ConfigurableExportParametersFactory.php line 74:
                                                                             
  Recommendation client export credentials are not set for siteAccess: site  

To have options automatically taken from configuration EzRecommendationClientCredentialsResolver should be inject instead of ExportCredentialsResolver. This allows users to use simple export command version e.g.:
php bin/console ibexa:recommendation:run-export --contentTypeIdList=13

There is a second way to use export command. User can pass options by himself but must pass all required options: customerId, licenseKey, siteaccess. If one of these options is missing then exception will be thrown:

Required parameters param_name1, param_name2 are missing

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@ciastektk ciastektk added the bug Something isn't working label Oct 28, 2021
@ciastektk ciastektk force-pushed the ibx-1341-fixed-inject-valid-credentials-resolver branch from 6d04cbf to c3139cb Compare October 29, 2021 05:21
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ciastektk ciastektk merged commit c7334eb into 2.1 Oct 29, 2021
@ciastektk ciastektk deleted the ibx-1341-fixed-inject-valid-credentials-resolver branch October 29, 2021 10:11
ciastektk added a commit that referenced this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

None yet

4 participants