EZP-27563: Handle a non responding server and JSON parsing error in Hybrid Platform UI #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const {response, text} = updateInfo; | ||
| let debugLink = ''; | ||
|
|
||
| if ( response.headers.has('X-Debug-Token-Link') ) { |
StephaneDiot
approved these changes
Jul 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-27563
Requires ezsystems/hybrid-platform-ui#60 (for links in notification to be readable)
Description
This PR changes
<ez-platform-ui-app>so that it correctly handles connection error and JSON parsing error and so that it notifies the user about that.For JSON parsing error, the notification also carries some details that can be copied and if the server is in dev mode, it contains a link to open the Symfony Profiler (thanks @bdunogier for the suggestion).
Also, while working on that part, I took the time to refactor it as suggested by @bdunogier a while back.
Screencast
Tests
manual test + unit test