EZP-27572: Markdown specs for the selection buttons. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephaneDiot
force-pushed
the
EZP-27572_Specs_Selection_Buttons
branch
from
6af4559
to
b20d6f5
Compare
dpobel
suggested changes
Jul 11, 2017
doc/spec/selection-button.md
Outdated
| ``` | ||
|
|
||
| *Constraints:* | ||
| input[type='checkbox'] |
doc/spec/selection-button.md
Outdated
|
|
||
|
|
||
| # Markup | ||
|
|
There was a problem hiding this comment.
maybe a short sentence saying the behavior is implemented in a custom element ez-selection-activate-element
doc/spec/selection-button.md
Outdated
|
|
||
| # Markup | ||
|
|
||
| * Here is a simple markup example of a selection button that can be enabled with one or more element and that can be enabled by every checkbox of <ez-selection-activate-element> : |
There was a problem hiding this comment.
instead of a list, add sub title, like:
## Enable a button based on a checkboxes
...
## Enable a button only if one element is selected
...
## Enable a button based on a subset of checkboxes
...
StephaneDiot
force-pushed
the
EZP-27572_Specs_Selection_Buttons
branch
from
b20d6f5
to
6778868
Compare
dpobel
suggested changes
Jul 17, 2017
doc/spec/selection-button.md
Outdated
|
|
||
| * Specification for https://jira.ez.no/browse/EZP-27572 | ||
|
|
||
| Goal here is to provide activable elements (like buttons) that are enabled and can triggers actions only if some elements of a list are selected. |
There was a problem hiding this comment.
please wrap line to something like 100
doc/spec/selection-button.md
Outdated
|
|
||
| # Markup | ||
|
|
||
| ## Enable a button based on a checkboxes |
There was a problem hiding this comment.
should be: ### Enable a button based on a checkbox
doc/spec/selection-button.md
Outdated
|
|
||
| This behavior is implemented by the `ez-selection-activate-element` custom element. | ||
|
|
||
| # Markup |
doc/spec/selection-button.md
Outdated
| @@ -0,0 +1,61 @@ | |||
| ## Provides the suggested markup for the selection buttons | |||
There was a problem hiding this comment.
# Enable button(s) based on a selection
doc/spec/selection-button.md
Outdated
| </ez-selection-activate-element> | ||
| ``` | ||
|
|
||
| ## Enable a button only if one element is selected |
There was a problem hiding this comment.
### Enable a button only if one element is selected
doc/spec/selection-button.md
Outdated
| ``` | ||
|
|
||
|
|
||
| ## Enable a button based on a subset of checkboxes |
doc/spec/selection-button.md
Outdated
| </ez-selection-activate-element> | ||
| ``` | ||
|
|
||
| *Constraints:* |
doc/spec/selection-button.md
Outdated
| *Constraints:* | ||
|
|
||
| * The activable element must have the `ez-js-activable-element` class. | ||
| * If the activable element should be enabled only by specific checkboxes or radio button, those must have a class that matches <ez-selection-activate-element>'s `selection-selector`. |
There was a problem hiding this comment.
The custom element should be between backticks
StephaneDiot
force-pushed
the
EZP-27572_Specs_Selection_Buttons
branch
from
6778868
to
a823233
Compare
dpobel
approved these changes
Jul 19, 2017
doc/spec/selection-button.md
Outdated
| activable element should have the `ez-js-activable-element-single-selection` in addition to | ||
| `ez-js-activable-element` class. | ||
|
|
||
| # How it works |
dpobel
force-pushed
the
EZP-27572_Specs_Selection_Buttons
branch
from
a823233
to
9678359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-27572
Suggested markdown for the selection buttons