EZP-27501: use pjax as a pagelayout #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunogier
force-pushed
the
ezp27501-use_pjax_as_pagelayout
branch
from
7a64779
to
827c026
Compare
bdunogier
force-pushed
the
ezp27501-use_pjax_as_pagelayout
branch
from
827c026
to
e9d847b
Compare
bdunogier
force-pushed
the
ezp27501-use_pjax_as_pagelayout
branch
from
d750253
to
31c333e
Compare
bdunogier
force-pushed
the
ezp27501-use_pjax_as_pagelayout
branch
from
31c333e
to
486c2af
Compare
bdunogier
force-pushed
the
ezp27501-use_pjax_as_pagelayout
branch
from
ebdb6a7
to
a4d3280
Compare
glye
approved these changes
Jun 28, 2017
| /** | ||
| * Matches a Pjax Http Response. | ||
| */ | ||
| interface PjaxResponseMatcher extends ResponseMatcherInterface |
There was a problem hiding this comment.
Why is one named -Interface and the other not?
There was a problem hiding this comment.
Yeah... 'cause I wanted ResponseMatcherInterface to be consistent with Symfony's RequestMatcherInterface. Do you see my dilemma ?
There was a problem hiding this comment.
Let's follow the trend, and go for Facey McInterface-face.
dpobel
approved these changes
Jun 29, 2017
| @@ -0,0 +1,15 @@ | |||
| <div data-name="title">{% block title %}{{ title|default('hybrid pagelayout title') }}{% endblock %}</div> | |||
There was a problem hiding this comment.
the default title should probably be an empty string
bdunogier
force-pushed
the
ezp27501-use_pjax_as_pagelayout
branch
from
a4d3280
to
0050219
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures
src/bundle/Resources/views/pagelayout.html.twigas the global pagelayout for theadmin_groupsiteaccess group. Core templates that use it, `such as content_edit.html.twig, will be rendered within the PJAX DOM and integrated in the Hybrid UI.In addition, adds a
PjaxResponseMatcher, used to detect PJAX responses by looking for<div data-name="html">in the content. It allows to match requests that don't identify by the URI or by the PJAX header.TODO