EZP-27569: Asynchronously load hidden Content view tabs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpobel
force-pushed
the
ezp-27569_async_tab
branch
from
44787af
to
92ed42c
Compare
4 tasks
dpobel
changed the title
|
(and ping @maxbaldanza and @mcurran-inviqa for next tabs) |
StephaneDiot
approved these changes
Jul 4, 2017
|
Looks good to me. But I guess that it requires that the backend is changed to return only the markup for the tabs, right ? We don't have anything yet in this regard do we ? |
|
actually, this is only needed when ezsystems/hybrid-platform-ui-core-components#25 will be merged (form submit handling in See #53 (and ezsystems/hybrid-platform-ui-core-components#25) for follow up patches related to forms in tabs. |
dpobel
force-pushed
the
ezp-27569_async_tab
branch
from
92ed42c
to
a5d2cd6
Compare
dpobel
force-pushed
the
ezp-27569_async_tab
branch
from
47190bc
to
497e6e6
Compare
bdunogier
reviewed
Jul 6, 2017
| </div> | ||
| <ez-asynchronous-block | ||
| class="ez-tabs-panel" id="ez-tab-details" | ||
| url="{{ path('_ez_content_view', {'contentId': contentId, 'locationId': locationId, 'viewType': 'details_tab'}) }}" |
There was a problem hiding this comment.
Opened ezsystems/ezpublish-kernel#2048 that would allow to simplify those links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-27569
Requires ezsystems/hybrid-platform-ui-core-components#23
See ezsystems/hybrid-platform-ui-core-components#23 for description and screencast.