Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibexa + PHP 8 #100

Merged
merged 10 commits into from
Feb 25, 2021
Merged

Ibexa + PHP 8 #100

merged 10 commits into from
Feb 25, 2021

Conversation

ddoghri
Copy link
Contributor

@ddoghri ddoghri commented Feb 8, 2021

Q A
Branch? master / x.y.z
Bug fix? yes/no
New feature? yes/no
BC breaks? yes/no
Fixed tickets #...

Copy link
Collaborator

@Plopix Plopix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome @ddoghri.
2 things:

  • I think we can refactor a little bit more the InitializeIbexa command to have more thing in common with InitializeeZ.
  • We need a way to get/mount nginx configuration from the vendor or somewhere.

Thanks!

cd ezplatform
# Copy nginx conf
echo "Copy nginx conf"
cp -r ../$PROVISIONING/dev/nginx/doc .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to find a better solution somehow. We don't want to put the nginx config in Launchpad because it means we need to maintain the config that can change on Ibexa side.. that would be too complex to handle.

So we need to find a better way.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

payload/recipes/ibexa_install.bash Show resolved Hide resolved
src/Command/Docker/InitializeIbexa.php Outdated Show resolved Hide resolved
src/Command/Docker/InitializeIbexa.php Outdated Show resolved Hide resolved
@Plopix Plopix force-pushed the feature-install-ibexa-3.3 branch 5 times, most recently from 8cca1d6 to 7c6bef7 Compare February 11, 2021 01:23
@Plopix Plopix changed the title Add a new command init_ibexa Ibexa + PHP 8 Feb 24, 2021
This was referenced Feb 24, 2021
@Plopix Plopix self-assigned this Feb 24, 2021
@Plopix Plopix self-requested a review February 24, 2021 01:46
.github/workflows/main-ci.yaml Outdated Show resolved Hide resolved
payload/recipes/ibexa_install.bash Show resolved Hide resolved

# Add .env.local to set database configuration
echo "Add .env.local to set database configuration"
echo "DATABASE_URL=\${DATABASE_PLATFORM}://\${DATABASE_USER}:\${DATABASE_PASSWORD}@\${DATABASE_HOST}:\${DATABASE_PORT}/\${DATABASE_NAME}?serverVersion=\${DATABASE_VERSION}" > ".env.local"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look like this part is missing support for DATABASE_PREFIXES

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, that's not really managed by Ibexa anyway. So for the install that should be fine.
Actually the multi db for install does not have to be supported. It is there but I don't really remember why. Do you? (you did it ;))

src/Command/Docker/Initialize.php Outdated Show resolved Hide resolved
src/Command/Docker/Initialize.php Outdated Show resolved Hide resolved
src/Core/TaskExecutor.php Outdated Show resolved Hide resolved
@Plopix Plopix merged commit f8b47f7 into ezsystems:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants