-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ibexa + PHP 8 #100
Ibexa + PHP 8 #100
Conversation
ddoghri
commented
Feb 8, 2021
Q | A |
---|---|
Branch? | master / x.y.z |
Bug fix? | yes/no |
New feature? | yes/no |
BC breaks? | yes/no |
Fixed tickets | #... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome @ddoghri.
2 things:
- I think we can refactor a little bit more the InitializeIbexa command to have more thing in common with InitializeeZ.
- We need a way to get/mount nginx configuration from the vendor or somewhere.
Thanks!
payload/recipes/ibexa_install.bash
Outdated
cd ezplatform | ||
# Copy nginx conf | ||
echo "Copy nginx conf" | ||
cp -r ../$PROVISIONING/dev/nginx/doc . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to find a better solution somehow. We don't want to put the nginx config in Launchpad because it means we need to maintain the config that can change on Ibexa side.. that would be too complex to handle.
So we need to find a better way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently that is there: https://github.com/ibexa/docker/tree/main/templates/nginx/ez_params.d
8cca1d6
to
7c6bef7
Compare
7c6bef7
to
b848c51
Compare
224fd9c
to
6178087
Compare
|
||
# Add .env.local to set database configuration | ||
echo "Add .env.local to set database configuration" | ||
echo "DATABASE_URL=\${DATABASE_PLATFORM}://\${DATABASE_USER}:\${DATABASE_PASSWORD}@\${DATABASE_HOST}:\${DATABASE_PORT}/\${DATABASE_NAME}?serverVersion=\${DATABASE_VERSION}" > ".env.local" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look like this part is missing support for DATABASE_PREFIXES
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, that's not really managed by Ibexa anyway. So for the install
that should be fine.
Actually the multi db for install
does not have to be supported. It is there but I don't really remember why. Do you? (you did it ;))