Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request For Review] Symfony 4, PHP 7.x, Github Actions #72

Merged
merged 4 commits into from
Nov 15, 2019

Conversation

Plopix
Copy link
Collaborator

@Plopix Plopix commented Nov 7, 2019

This PR revamps eZ Launchpad on Symfony 4.4 (soon released) and to PHP 7.2 minimum as support for other versions is gone.

It also greatly improves the release mechanism using now Github Actions and Github Release.

Github Actions are not available yet on eZ Systems repository but you can see the result there:

Todos:

  • PHP 7 Type Hints
  • Syfmony 4.3 migration
  • Move to PSR12
  • Remove all unnecessary Doc Block
  • Symfony 4.4 migration
  • Remove useless templates
  • Improve CI
  • Improve release mechanism
  • Get rid of Travis files

So now we are just waiting for Symfony 4.4 and double-check everything. But that could definitely be merged before.

Also Github Conference is in 2 days, and Github Actions should be available for eZ Systems Org as well (I hope..)

What do you think?

@Plopix Plopix changed the title [WiP] Symfony 4, PHP 7.x [Request For Review] Symfony 4, PHP 7.x, Github Actions Nov 11, 2019
@Plopix
Copy link
Collaborator Author

Plopix commented Nov 11, 2019

ping @crevillo @nicolasaguenot and @amirkoklan as I think you are using it a lot ;-)

@amirkoklan
Copy link

amirkoklan commented Nov 13, 2019

ping @crevillo @nicolasaguenot and @amirkoklan as I think you are using it a lot ;-)

I'm back and give this a try tomorrow as the first thing

@andrerom
Copy link
Contributor

code wise looks about ok, on requirements side not supporting 7.1 means it's not in sync with neither 2.5 or 3.x requirements, but it's up to you.

@Plopix
Copy link
Collaborator Author

Plopix commented Nov 13, 2019

hey @andrerom thanks for the feedback. Actually the limitation is not for eZ but for Launchpad which is the CLI that runs on the host. PHP version for eZ Platform is managed in the Docker Container engine as usual.

@Plopix Plopix merged commit 1c05fdd into master Nov 15, 2019
@Plopix Plopix deleted the feature-symfony4 branch November 15, 2019 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants