EZP-27819: Template exception when editing policies with no node and subtree limitation #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…subtree limitation
andrerom
approved these changes
Aug 29, 2017
adamwojs
approved these changes
Aug 29, 2017
|
@andrerom Yep, I've verified 1.7 is not affected, FT only. |
|
Sent to QA. |
|
Update: 1.7 is affected now, at least. Reports are not all testers are affected by it. Cherry-picked in 1.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When editing limitations for a policy that can have Node and Subtree limitations, but doesn't, Twig throws an exception because it is trying to render a Location with an empty string as ID.
Fixing this by verifying we have an ID to render. Thanks to @Plopix!