EZP-27884: Create extensibility point for views overriding in content edit and draft create #158
Conversation
webhdx
changed the title
webhdx
force-pushed
the
configurable-views
branch
from
4a9b777
to
5a66adc
Compare
| @@ -69,7 +73,7 @@ public function __construct( | |||
| * @param int $parentLocationId Location the content should be a child of | |||
| * @param \Symfony\Component\HttpFoundation\Request $request | |||
| * | |||
| * @return \Symfony\Component\HttpFoundation\Response | |||
| * @return \EzSystems\RepositoryForms\Content\View\ContentEditView|\Symfony\Component\HttpFoundation\Response | |||
There was a problem hiding this comment.
Note: I'm not a huge fan of returning multiple unrelated object types. Of course refactoring everything now does not make sense, but please be aware of technical debt it creates when in some distant future we'll decide to use strict PHP7 :)
There was a problem hiding this comment.
Sure. Unfortunately we can't avoid doing so. Response objects doesn't allow any extensibility because they come with rendered HTML.
| * @copyright Copyright (C) eZ Systems AS. All rights reserved. | ||
| * @license For full copyright and license information view LICENSE file distributed with this source code. | ||
| * | ||
| * @version //autogentag// |
There was a problem hiding this comment.
Nitpick: we no longer use @version for anything, to be removed in new code.
bundle/Resources/config/services.yml
Outdated
| - [setPagelayout, ["$pagelayout$"]] | ||
|
|
||
| ezrepoforms.user_register.view_templates_listener: | ||
| alias: ezrepoforms.view_templates_listener | ||
| depracated: 'The "%service_id%" service is deprecated since 1.10 and will be removed in 2.0. Use "ezrepoforms.view_templates_listener" instead.' |
| 'form' => $form->createView(), | ||
| 'languageCode' => $language, | ||
| 'pagelayout' => $this->pagelayout, |
There was a problem hiding this comment.
Is this setting passed to the view somewhere else? I'm not a Twig expert, just asking :)
There was a problem hiding this comment.
Yes. pagelayout is now passed via ViewTemplatesListener. This allows us to attach different pagelayout for admin UI.
webhdx
force-pushed
the
configurable-views
branch
from
5a66adc
to
e394a02
Compare
|
@alongosz Fixed. |
Description
Changed return type of the controller's actions. It now returns
Viewobjects which are rendered byViewManager. Templates are injected from parameters which can be easily configured. It uses the same principle as UserRegister.