EZP-28224: Fix Behat tests #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
approved these changes
Apr 12, 2018
|
Nice catch @mnocon! :) |
alongosz
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.ez.no/browse/EZP-28224
Three things had to be changed in order to make the tests pass:
in the page source, which AFAIK are only displayed when Debug is enabled.
Changing the way these strings are searched for: recently the format changed a bit (Display real template names in debug output ezpublish-kernel#2285), I've switched to Regex to account for that.
Permissions: tests were trying to create a directory in
app/Resources, but by default the www-data is owner of theapp/configandsrc(https://github.com/ezsystems/ezplatform/blob/1.7/bin/.travis/trusty/setup_from_external_repo.sh#L68). I've switched the tests so that they are creating it insrc/AppBundlenow.