EZP-29849: Allow user to remove location in subtree limitation #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamwojs
requested review from
mikadamczyk,
Nattfarinn,
pawbuj,
webhdx,
ViniTou and
tischsoic
This comment has been minimized.
This comment has been minimized.
ViniTou
reviewed
Jan 17, 2019
| return null; | ||
| } | ||
|
|
||
| return array_map(function (Location $location) { |
There was a problem hiding this comment.
don't know if this even matters, but that could be replaced with array_column.
ViniTou
approved these changes
Jan 17, 2019
|
PR updated according to @ViniTou suggestions. |
This comment has been minimized.
This comment has been minimized.
pawbuj
approved these changes
Jan 24, 2019
webhdx
approved these changes
Jan 25, 2019
| } | ||
|
|
||
| try { | ||
| return array_map(function ($id) { |
There was a problem hiding this comment.
No need for closure:
return array_map([$this->locationService, 'loadLocation'], explode(self::DELIMITER, $value));
|
PR updated according to @webhdx suggestions. |
katarzynazawada
approved these changes
Jan 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes required to make Location object available during rendering edit form of the location based limitations.
In the limitation template (e.g.
src/bundle/Resources/views/Limitation/udw_limitation_value.html.twiginezplatform-admin-ui) location instances are available usingform.limitationValues.vars.data. The model/view format of data is not changed: