Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31350: [1.1] Update cache adapters from Symfony 4.4 #10

Merged
merged 9 commits into from Feb 3, 2020
Merged

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Jan 22, 2020

Jira: https://jira.ez.no/browse/EZP-31350

Backport changes that happened since the adapters where proposed last winter, until it was accepted and improved further within Symfony codebase.

Benefits:

  • Removes requirement for phpredis 3.1.3, which was an issue on platform.sh on PHP 7.1 and PHP 7.2 (currently needed with eZ Commerce for instance), and in some development environments compiled with older extension
  • Logs message & refuses to save cache if Redis server has been configured with wrong eviction policy
  • Should be able to handler larger cache pool, as cache clearing by tag is done in batches
    • Redis details for Tag Set usage: 1. Rename Set to be atomic 2. Read batch of keys 3. delete ➰ back to 2. till empty
  • Now a almost pure backported Adapter, easier to maintain and works as polyfill for Symfony 4.4 with same namespace / class name

Cons:

TODO:

  • Travis
  • QA (including making sure this does not break 2.5 in anyway)

@andrerom
Copy link
Contributor Author

andrerom commented Jan 22, 2020

Tagged a RC for testing this: https://github.com/ezsystems/symfony-tools/releases/tag/v1.1.0-rc

@reithor I think you worked around the issue you had with commerce => php 7.2 + redis on platform.sh, but you can try this out if you want to use the default adapters (adjust composer.json for this package to ^1.1@rc).

@micszo Can we aim to test this with next 2.5.x release? Besides what is mentioned above it should hopefully solve several recurring configuration issues with RedisServer being reported to Support & PS.

@micszo
Copy link
Member

micszo commented Jan 22, 2020

OK, I'll keep an eye for the next release.

@andrerom
Copy link
Contributor Author

andrerom commented Feb 3, 2020

Merging this to master, testing to be done on meta repo PR for the switch to 1.1.

@andrerom andrerom merged commit 31d0510 into master Feb 3, 2020
@andrerom andrerom deleted the 1.1 branch February 3, 2020 13:55
@andrerom andrerom changed the title [1.1] Update cache adapters from Symfony 4.4 EZP-31350: [1.1] Update cache adapters from Symfony 4.4 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants