New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31350: [1.1] Update cache adapters from Symfony 4.4 #10
Conversation
This reverts commit 6bde8cb.
Tagged a RC for testing this: https://github.com/ezsystems/symfony-tools/releases/tag/v1.1.0-rc @reithor I think you worked around the issue you had with commerce => php 7.2 + redis on platform.sh, but you can try this out if you want to use the default adapters (adjust composer.json for this package to @micszo Can we aim to test this with next 2.5.x release? Besides what is mentioned above it should hopefully solve several recurring configuration issues with RedisServer being reported to Support & PS. |
OK, I'll keep an eye for the next release. |
Merging this to master, testing to be done on meta repo PR for the switch to 1.1. |
Jira: https://jira.ez.no/browse/EZP-31350
Backport changes that happened since the adapters where proposed last winter, until it was accepted and improved further within Symfony codebase.
Benefits:
Set
usage: 1. Rename Set to be atomic 2. Read batch of keys 3. delete ➰ back to 2. till emptyCons:
phpredis OR Predis
. Ref: [Cache] Improve RedisTagAwareAdapter invalidation logic & requirements symfony/symfony#33461 (review)TODO: