ghstack is not compatible with git-2.17 (default for Ubuntu-18.04)

[malfet]

As it uses git config --default, which were added later

$ git config --default /fsx/users/nshulga/git/pytorch/pytorch/.git/hooks --get core.hooksPath
error: unknown option `default'
usage: git config [<options>]

Config file location
    --global              use global config file
    --system              use system config file
    --local               use repository config file
    -f, --file <file>     use given config file
    --blob <blob-id>      read config from given blob object

Action
    --get                 get value: name [value-regex]
    --get-all             get all values: key [value-regex]
    --get-regexp          get values for regexp: name-regex [value-regex]
    --get-urlmatch        get value specific for the URL: section[.var] URL
    --replace-all         replace all matching variables: name value [value_regex]
    --add                 add a new variable: name value
    --unset               remove a variable: name [value-regex]
    --unset-all           remove all matches: name [value-regex]
    --rename-section      rename section: old-name new-name
    --remove-section      remove a section: name
    -l, --list            list all
    -e, --edit            open an editor
    --get-color           find the color configured: slot [default]
    --get-colorbool       find the color setting: slot [stdout-is-tty]

Type
    --bool                value is "true" or "false"
    --int                 value is decimal number
    --bool-or-int         value is --bool or --int
    --path                value is a path (file or directory name)
    --expiry-date         value is an expiry date

Other
    -z, --null            terminate values with NUL byte
    --name-only           show variable names only
    --includes            respect include directives on lookup
    --show-origin         show origin of config (file, standard input, blob, command line)

ERROR: Fatal exception
Traceback (most recent call last):
  File "/fsx/users/nshulga/conda/lib/python3.8/site-packages/ghstack/logs.py", line 107, in manager
    yield
  File "/fsx/users/nshulga/conda/lib/python3.8/site-packages/ghstack/__main__.py", line 101, in main
    ghstack.submit.main(
  File "/fsx/users/nshulga/conda/lib/python3.8/site-packages/ghstack/submit.py", line 179, in main
    run_pre_ghstack_hook(sh, base, stack[0].oid)
  File "/fsx/users/nshulga/conda/lib/python3.8/site-packages/ghstack/submit.py", line 1062, in run_pre_ghstack_hook
    hooks_path = sh.git("config", "--default", default_hooks_path, "--get", "core.hooksPath")
  File "/fsx/users/nshulga/conda/lib/python3.8/site-packages/ghstack/shell.py", line 273, in git
    return self._maybe_rstrip(self.sh(*(("git",) + args), **kwargs))
  File "/fsx/users/nshulga/conda/lib/python3.8/site-packages/ghstack/shell.py", line 210, in sh
    raise RuntimeError(
RuntimeError: git config --default /fsx/users/nshulga/git/pytorch/pytorch/.git/hooks --get core.hooksPath failed with exit code 129
(base) nshulga@nshulga-2208-7c76d986d-4j8kj:/fsx/users/nshulga/git/pytorch/pytorch$ which git
/usr/bin/git
(base) nshulga@nshulga-2208-7c76d986d-4j8kj:/fsx/users/nshulga/git/pytorch/pytorch$ git --version
git version 2.17.1

[Zacharias030]

Discussed here as well #97.

Updating git solved it for me. See
https://unix.stackexchange.com/questions/33617/how-can-i-update-to-a-newer-version-of-git-using-apt-get

[ezyang]

it's fixed in 6bc3339