PHP 7.2: "__autoload() is deprecated, use spl_autoload_register() instead"

[zerocrates]

The mere presence of the __autoload function definition, even inside the conditional, seems to raise this warning on PHP 7.2. It's just a deprecation warning but it will crop up and cause problems for people running tests and things like that (where I saw it).

Simply eliminating the __autoload fallback from HTMLPurifier.autoload.php
would quiet the complaint. As it's only support for ancient versions it might be prudent to do so.

Otherwise, I suppose you could split off the __autoload definition into a separate file that would only be conditionally include'd, thus making it so the problematic definition isn't visible when it's not needed.

[ezyang]

OK! I'll take a patch that does this.

[zerocrates]

which? dropping the fallback or separating it out?

[ezyang]

Separating it out please!

[3alampro]

@ezyang kindly can we have release for this so we can update our project with composer update

[ezyang]

OK, one of these days :)

[brandonfarber]

Anything we can do to help speed up getting a new build? HTMLPurifier is essentially broken on PHP 7.2 presently, which is general release and thus has to be supported in most projects.

[ezyang]

4.10.0 is out.

[guruskid]

replace line 45
function __autoload($classname)
{
PHPMailerAutoload($classname);
}

with

spl_autoload_register(function($class) {
PHPMailerAutoload($classname);
});

[SmartGuyCodes]

Auto load classes

1. OLD WAY EXAMPLE

function __autoload($className){
	if(file_exists(DIR_FS_CLASSES . "class." . $className . ".php"))
		include DIR_FS_CLASSES . "class." . $className . ".php";
}

2. NEW WAY EXAMPLE

spl_autoload_register(function($className) {
    if(file_exists(DIR_FS_CLASSES . "class." . $className . ".php"))
		include DIR_FS_CLASSES . "class." . $className . ".php";
});