Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve stack trie suffix pruning #47

Open
ezyang opened this issue Jun 19, 2024 · 0 comments
Open

Improve stack trie suffix pruning #47

ezyang opened this issue Jun 19, 2024 · 0 comments

Comments

@ezyang
Copy link
Owner

ezyang commented Jun 19, 2024

I'm still regularly seeing stack tries that look like this:

torch/nn/modules/module.py:1566 in _wrapped_call_impl
torch/nn/modules/module.py:1575 in _call_impl
torch/_dynamo/eval_frame.py:433 in _fn
torch/nn/modules/module.py:1566 in _wrapped_call_impl
torch/nn/modules/module.py:1575 in _call_impl
torch/_dynamo/convert_frame.py:1116 in __call__
[[2/0]](https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmp0umcnJ/index.html#[2/0]) [[2/1]](https://interncache-all.fbcdn.net/manifold/tlparse_reports/tree/logs/.tmp0umcnJ/index.html#[2/1]) torch/_dynamo/convert_frame.py:472 in __call__

The torch/_dynamo/convert_frame.py:1116 in __call__ definitely need to be killed. But there's also some funny business with _wrapped_call_impl indirection that also is unnecessary 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant