[DOC] Fully document HBPConv2d
#290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convolution layers with a single output behave like linear layers, as the weights are not shared over the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds documentation to the
HBPextension ofConv2dlayers, which is responsible to computeKFAC/KFLR/KFRA. The docstrings draw connections to the notation in the KFC paper, and outline important differences, as well as improvements for consistency. It also adds a test case forKFAC, KFLRfor which both approximations become exact.Note to myself: I made notes how to connect Hessian backpropagation to
KFACfor convolutions by imposing a Kronecker structure on the backpropagated quantity. This concept can also be applied toKFRAto achieve more consistency, but is currently not done by the code.