[ADD] Forbid subsampling with repeated indices
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1863916071
💛 - Coveralls |
f-dangel
added a commit
that referenced
this pull request
Feb 18, 2022
* [REF] Rename file containing argument checks * [ADD] Forbid sub-sampling with repeated indices Co-authored-by: Felix Dangel <fdangel@tue.mpg.de>
f-dangel
added a commit
that referenced
this pull request
Feb 21, 2022
Exotic features, like using different GGNs to compute directions and directional curvatures, as well as full control of which intermediate buffers to keep, have been deprecated in favor of a simpler API. - Remove Newton step computation for now as it was internally relying on `DirectionalDerivatives` - Remove many utilities and associated tests from the exotic features - Forbid duplicate indices in `subsampling` - Always delete intermediate buffers other than the target quantities --- * [REF] Rename `GramComputations` → `DirectionalDerivativesComputation` * [DEL] Remove `compute_gammas` and `keep_gammas` arguments Always compute and keep first-order directional derivatives. * [DEL] Remove `compute_lambdas` and `keep_lambdas` arguments * [DEL] Remove Newton step and Newton optimizer Currently, the Newton step depends on the directional derivatives. I will be easier to clean up the latter's API before reactivating the Newton step feature. * [DEL] Remove `keep_gram_mat` argument Always delete the Gram matrix. * [DEL] Remove `keep_gram_evecs` argument Always remove the Gram matrix eigenvectors. * [DEL] Remove `keep_gram_evals` argument Always delete the Gram matrix eigenvalues. * [DEL] Remove `keep_batch_size` argument Always delete batch size. * [DEL] Remove `keep_backpack_buffers` argument Always delete BackPACK buffers. * [DEL] Remove `param_groups` from `get_extensions` * [ADD] Simplify `DirectionalDerivativesComputation` API and tests * [ADD] Forbid `subsampling` with repeated indices (#16) * [REF] Rename file containing argument checks * [ADD] Forbid sub-sampling with repeated indices Co-authored-by: Felix Dangel <fdangel@tue.mpg.de> * [ADD] Simplify internals of `DirectionalDerivativesComputation` Forbid duplicates in subsampling, share subsampling for directions and directional curvatures. Co-authored-by: Felix Dangel <fdangel@tue.mpg.de>
f-dangel
added a commit
that referenced
this pull request
Feb 22, 2022
- Inline parameter computations and group hooks - Remove `stable_symeig` - Recycle functionality from `vivit.linalg` --- [REF] Rename `GramComputations` → `DirectionalDerivativesComputation` * [DEL] Remove `compute_gammas` and `keep_gammas` arguments Always compute and keep first-order directional derivatives. * [DEL] Remove `compute_lambdas` and `keep_lambdas` arguments * [DEL] Remove Newton step and Newton optimizer Currently, the Newton step depends on the directional derivatives. I will be easier to clean up the latter's API before reactivating the Newton step feature. * [DEL] Remove `keep_gram_mat` argument Always delete the Gram matrix. * [DEL] Remove `keep_gram_evecs` argument Always remove the Gram matrix eigenvectors. * [DEL] Remove `keep_gram_evals` argument Always delete the Gram matrix eigenvalues. * [DEL] Remove `keep_batch_size` argument Always delete batch size. * [DEL] Remove `keep_backpack_buffers` argument Always delete BackPACK buffers. * [DEL] Remove `param_groups` from `get_extensions` * [ADD] Simplify `DirectionalDerivativesComputation` API and tests * [ADD] Forbid `subsampling` with repeated indices (#16) * [REF] Rename file containing argument checks * [ADD] Forbid sub-sampling with repeated indices Co-authored-by: Felix Dangel <fdangel@tue.mpg.de> * [ADD] Simplify internals of `DirectionalDerivativesComputation` Forbid duplicates in subsampling, share subsampling for directions and directional curvatures. * [REF] Use `accumulation` instead of attributes to transfer quantities * [REF] Inline parameter computations * [TEST] Increase `atol` to make GPU tests pass * [REF] Use `Tensor.symeig` and remove `stable_symeig` * [REF] Inline `group_hook_directions` * [REF] Inline `group_hook_filter_directions` * [REF] Inline `group_hook_gammas` * [REF] Inline `group_hook_lambdas` * [REF] Inline `group_hook_memory_cleanup` * [REF] Pop batch size straight * [REF] Reduce duplication in group hook * [REF] Use batch size hook from `vivit.linalg` utilities Co-authored-by: Felix Dangel <fdangel@tue.mpg.de>
f-dangel
added a commit
that referenced
this pull request
Mar 24, 2022
* [REF] Rename file containing argument checks * [ADD] Forbid sub-sampling with repeated indices Co-authored-by: Felix Dangel <fdangel@tue.mpg.de>
f-dangel
added a commit
that referenced
this pull request
Mar 24, 2022
Exotic features, like using different GGNs to compute directions and directional curvatures, as well as full control of which intermediate buffers to keep, have been deprecated in favor of a simpler API. - Remove Newton step computation for now as it was internally relying on `DirectionalDerivatives` - Remove many utilities and associated tests from the exotic features - Forbid duplicate indices in `subsampling` - Always delete intermediate buffers other than the target quantities --- * [REF] Rename `GramComputations` → `DirectionalDerivativesComputation` * [DEL] Remove `compute_gammas` and `keep_gammas` arguments Always compute and keep first-order directional derivatives. * [DEL] Remove `compute_lambdas` and `keep_lambdas` arguments * [DEL] Remove Newton step and Newton optimizer Currently, the Newton step depends on the directional derivatives. I will be easier to clean up the latter's API before reactivating the Newton step feature. * [DEL] Remove `keep_gram_mat` argument Always delete the Gram matrix. * [DEL] Remove `keep_gram_evecs` argument Always remove the Gram matrix eigenvectors. * [DEL] Remove `keep_gram_evals` argument Always delete the Gram matrix eigenvalues. * [DEL] Remove `keep_batch_size` argument Always delete batch size. * [DEL] Remove `keep_backpack_buffers` argument Always delete BackPACK buffers. * [DEL] Remove `param_groups` from `get_extensions` * [ADD] Simplify `DirectionalDerivativesComputation` API and tests * [ADD] Forbid `subsampling` with repeated indices (#16) * [REF] Rename file containing argument checks * [ADD] Forbid sub-sampling with repeated indices Co-authored-by: Felix Dangel <fdangel@tue.mpg.de> * [ADD] Simplify internals of `DirectionalDerivativesComputation` Forbid duplicates in subsampling, share subsampling for directions and directional curvatures. Co-authored-by: Felix Dangel <fdangel@tue.mpg.de>
f-dangel
added a commit
that referenced
this pull request
Mar 24, 2022
- Inline parameter computations and group hooks - Remove `stable_symeig` - Recycle functionality from `vivit.linalg` --- [REF] Rename `GramComputations` → `DirectionalDerivativesComputation` * [DEL] Remove `compute_gammas` and `keep_gammas` arguments Always compute and keep first-order directional derivatives. * [DEL] Remove `compute_lambdas` and `keep_lambdas` arguments * [DEL] Remove Newton step and Newton optimizer Currently, the Newton step depends on the directional derivatives. I will be easier to clean up the latter's API before reactivating the Newton step feature. * [DEL] Remove `keep_gram_mat` argument Always delete the Gram matrix. * [DEL] Remove `keep_gram_evecs` argument Always remove the Gram matrix eigenvectors. * [DEL] Remove `keep_gram_evals` argument Always delete the Gram matrix eigenvalues. * [DEL] Remove `keep_batch_size` argument Always delete batch size. * [DEL] Remove `keep_backpack_buffers` argument Always delete BackPACK buffers. * [DEL] Remove `param_groups` from `get_extensions` * [ADD] Simplify `DirectionalDerivativesComputation` API and tests * [ADD] Forbid `subsampling` with repeated indices (#16) * [REF] Rename file containing argument checks * [ADD] Forbid sub-sampling with repeated indices Co-authored-by: Felix Dangel <fdangel@tue.mpg.de> * [ADD] Simplify internals of `DirectionalDerivativesComputation` Forbid duplicates in subsampling, share subsampling for directions and directional curvatures. * [REF] Use `accumulation` instead of attributes to transfer quantities * [REF] Inline parameter computations * [TEST] Increase `atol` to make GPU tests pass * [REF] Use `Tensor.symeig` and remove `stable_symeig` * [REF] Inline `group_hook_directions` * [REF] Inline `group_hook_filter_directions` * [REF] Inline `group_hook_gammas` * [REF] Inline `group_hook_lambdas` * [REF] Inline `group_hook_memory_cleanup` * [REF] Pop batch size straight * [REF] Reduce duplication in group hook * [REF] Use batch size hook from `vivit.linalg` utilities Co-authored-by: Felix Dangel <fdangel@tue.mpg.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.