Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added message for low funds #181

Merged
merged 9 commits into from
Sep 3, 2023
Merged

Conversation

joandrsn
Copy link
Contributor

@joandrsn joandrsn commented Oct 1, 2019

If you have under a balance under 5000, you should get a message, notifying you that you might soon be banned.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 81.483% when pulling bb93ad4 on joandrsn:print-low-balance into 6464b92 on f-klubben:next.

Copy link
Collaborator

@VirtualSatai VirtualSatai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

{% if showmemberbalance %}
<br>
<b>
Tilbagestående beløb: {{newmemberbalance}}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a hint that they should insert more money soon.

@jenrik
Copy link
Member

jenrik commented Oct 7, 2019

I don't think we should leave peoples balance visible, I think either there should be timeout after which the message disappear, or the message should only state that the account balance is below 5000, or both

@joandrsn
Copy link
Contributor Author

Agree. I would like to wait for #182 to be merged.

@jenrik
Copy link
Member

jenrik commented Apr 8, 2020

@joandrsn #182 has been merged, should we look at getting this merged too?

@joandrsn
Copy link
Contributor Author

joandrsn commented Oct 2, 2020

I have updated the code to remove the remaning amount, using the same method as in #182
Maybe @hrjakobsen or @cogitantium can review this PR?

stregsystem/models.py Outdated Show resolved Hide resolved
stregsystem/templates/stregsystem/index_sale.html Outdated Show resolved Hide resolved
Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@JakobTopholt
Copy link

LGTM

@krestenlaust
Copy link
Member

Feature branch needs to catch up with next. 170 commits behind

@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2023

Codecov Report

Merging #181 (a2f3648) into next (a1b3702) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a2f3648 differs from pull request most recent head 08d2503. Consider uploading reports for the commit 08d2503 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             next     #181      +/-   ##
==========================================
+ Coverage   80.51%   80.53%   +0.02%     
==========================================
  Files          32       32              
  Lines        2812     2816       +4     
  Branches      217      217              
==========================================
+ Hits         2264     2268       +4     
  Misses        513      513              
  Partials       35       35              
Files Changed Coverage Δ
stregsystem/views.py 46.23% <100.00%> (+0.54%) ⬆️

…ve and API, add blink to balance for eye-catching
@falkecarlsen
Copy link
Member

@joandrsn made feature catch up and added blinking, note that only Chrome-based browsers load gdpr.js for some reason.

@falkecarlsen falkecarlsen merged commit 8023272 into f-klubben:next Sep 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants