Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix mobilepayment #247

Merged
merged 5 commits into from
Sep 8, 2021
Merged

Bugfix mobilepayment #247

merged 5 commits into from
Sep 8, 2021

Conversation

falkecarlsen
Copy link
Member

  • Turns out customer_name was non-null non-blank was disallowed, however our MobilePay API does not give us this data, so it should be nullable when/if we get this additional data. This data could make payment matching better.
  • MySQL in production does not support emojies, which makes cronjob-autopayment fail. Added stripping util method to comment from MobilePay API .

@codecov-commenter
Copy link

Codecov Report

Merging #247 (e072355) into next (162b640) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #247      +/-   ##
==========================================
+ Coverage   82.42%   82.48%   +0.06%     
==========================================
  Files          30       30              
  Lines        2247     2255       +8     
  Branches      157      157              
==========================================
+ Hits         1852     1860       +8     
  Misses        370      370              
  Partials       25       25              
Impacted Files Coverage Δ
stregsystem/models.py 90.68% <100.00%> (ø)
stregsystem/tests.py 99.73% <100.00%> (+<0.01%) ⬆️
stregsystem/utils.py 73.86% <100.00%> (+1.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 162b640...e072355. Read the comment docs.

@falkecarlsen falkecarlsen merged commit 7ace8fd into next Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants