-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature making the QR-codes clickable #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, LGTM. Thanks!
Co-authored-by: Falke Carlsen <11318702+falkecarlsen@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## next #278 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 31 31
Lines 2669 2669
Branches 189 189
=======================================
Hits 2215 2215
Misses 421 421
Partials 33 33
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I may be nitpicking, but the PR seems to change formatting which isn't related to the PR. It would be prettier if that was in a separate commit or PR (+1 for Hacktoberfest as well). |
You're right but we don't have code-style rules for HTML (yet), so it effectively doesn't matter. If @denn4617 wants to pump their PRs, they are welcome to revert the style changes and do them in another PR. |
I would love to have an automated style guide, but I don't know of any tool that can handle the Django template language since it essentially allows for arbitrary Django everywhere in the HTML. At least the popular |
Closes #270.
Added a feature which makes the QR-codes clickable. This makes it more convenient for mobile users, since they can't scan the QR. When clicking the QR-code a 'href' will redirect to the mobilepay query, which takes to parameters: username and amount.