Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature making the QR-codes clickable #278

Merged
merged 9 commits into from
Nov 11, 2022

Conversation

denn4617
Copy link
Contributor

@denn4617 denn4617 commented Oct 6, 2021

Closes #270.
Added a feature which makes the QR-codes clickable. This makes it more convenient for mobile users, since they can't scan the QR. When clicking the QR-code a 'href' will redirect to the mobilepay query, which takes to parameters: username and amount.

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, LGTM. Thanks!

stregsystem/views.py Outdated Show resolved Hide resolved
Co-authored-by: Falke Carlsen <11318702+falkecarlsen@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #278 (5a00c68) into next (0860feb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #278   +/-   ##
=======================================
  Coverage   82.98%   82.98%           
=======================================
  Files          31       31           
  Lines        2669     2669           
  Branches      189      189           
=======================================
  Hits         2215     2215           
  Misses        421      421           
  Partials       33       33           
Impacted Files Coverage Δ
stregsystem/views.py 56.71% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hrjakobsen
Copy link
Member

I may be nitpicking, but the PR seems to change formatting which isn't related to the PR. It would be prettier if that was in a separate commit or PR (+1 for Hacktoberfest as well).

@falkecarlsen
Copy link
Member

falkecarlsen commented Oct 7, 2021

I may be nitpicking, but the PR seems to change formatting which isn't related to the PR. It would be prettier if that was in a separate commit or PR (+1 for Hacktoberfest as well).

You're right but we don't have code-style rules for HTML (yet), so it effectively doesn't matter. If @denn4617 wants to pump their PRs, they are welcome to revert the style changes and do them in another PR.
@denn4617, let me know - then I'll hold off on deploying this :)

@hrjakobsen
Copy link
Member

but we don't have code-style rules for HTML (yet)

I would love to have an automated style guide, but I don't know of any tool that can handle the Django template language since it essentially allows for arbitrary Django everywhere in the HTML. At least the popular prettier doesn't support it prettier/prettier#5581

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it so, that QR codes are clickable, for if you're on phone.
4 participants