Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caffeine #290

Merged
merged 39 commits into from
Dec 13, 2021
Merged

Caffeine #290

merged 39 commits into from
Dec 13, 2021

Conversation

IdaThoft
Copy link
Contributor

@IdaThoft IdaThoft commented Nov 29, 2021

A caffeine calculator that displays mg of caffeine in your body when you buy caffeine products.
It also calculates the number of coffee cups corresponding to your caffeine level.
The calculator is only displayed when you buy a caffeine product
Lastly, it also finds the coffee master of the week!

caffeine calculator:
image
image

Coffe master:
image

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, more ranking is more better 👍

stregsystem/tests.py Outdated Show resolved Hide resolved
stregsystem/migrations/0015_product_caffine_content_ml.py Outdated Show resolved Hide resolved
stregsystem/views.py Outdated Show resolved Hide resolved
stregsystem/views.py Outdated Show resolved Hide resolved
Copy link
Contributor

@AndersSpringborg AndersSpringborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tror den er der nu! 🤠

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2021

Codecov Report

Merging #290 (e3f27cd) into next (5e89574) will increase coverage by 0.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next     #290      +/-   ##
==========================================
+ Coverage   82.44%   83.39%   +0.94%     
==========================================
  Files          30       31       +1     
  Lines        2336     2463     +127     
  Branches      167      176       +9     
==========================================
+ Hits         1926     2054     +128     
+ Misses        381      380       -1     
  Partials       29       29              
Impacted Files Coverage Δ
stregsystem/admin.py 73.40% <ø> (ø)
stregsystem/caffeine.py 100.00% <100.00%> (ø)
stregsystem/models.py 88.16% <100.00%> (+0.70%) ⬆️
stregsystem/templatetags/stregsystem_extras.py 100.00% <100.00%> (ø)
stregsystem/tests.py 99.77% <100.00%> (+0.02%) ⬆️
stregsystem/views.py 61.92% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e89574...e3f27cd. Read the comment docs.

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disliked the addition of the two dependencies, so I refactored the feature and added some more tests :shipit:

Copy link
Member

@Zaph-x Zaph-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@falkecarlsen falkecarlsen merged commit b4ed954 into f-klubben:next Dec 13, 2021
@AndersSpringborg AndersSpringborg deleted the caffeine branch December 13, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants