Ignore less than 50.00 DKK in AutoPayment #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #311 +/- ##
==========================================
+ Coverage 82.87% 83.07% +0.19%
==========================================
Files 31 31
Lines 2628 2659 +31
Branches 188 188
==========================================
+ Hits 2178 2209 +31
Misses 418 418
Partials 32 32
Continue to review full report at Codecov.
|
falkecarlsen
approved these changes
May 27, 2022
There was a problem hiding this comment.
This is a fine stopgap but we need a better solution for handling mobilepayments that does not meet our requirements (<50 DKK) and may need refunds (requiring mobilepay API refunding, which is further hampered by their new rules regarding covering any refunds off of incomes within the same business day).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stops AutoPayment from automatically accepting less than 50.00 DKK MobilePayments.
This is to encourage members to deposit more than 49.99 DKK to minimize the amount of transactionsfees in MobilePay.
Additionally this PR also removes the "Approved" logentry for a MobilePayment.
This is to lessen the spam in the logentries. The entry is already logged when there is created a new payment entry.
In the image below, the top element would be removed.