Added api endpoints #320
Merged
Added api endpoints #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkecarlsen
requested changes
Oct 19, 2022
Codecov Report
@@ Coverage Diff @@
## next #320 +/- ##
==========================================
- Coverage 83.07% 80.33% -2.74%
==========================================
Files 31 31
Lines 2659 2782 +123
Branches 188 214 +26
==========================================
+ Hits 2209 2235 +26
- Misses 418 515 +97
Partials 32 32
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LowkeyCoding
added a commit
to f-klubben/fappen
that referenced
this pull request
Oct 21, 2022
11 tasks
jonasKjellerup
requested changes
Nov 11, 2022
Comment on lines
+602
to
+603
| if username != member.username: | ||
| return HttpResponseBadRequest("Username does not match member_id") |
There was a problem hiding this comment.
Is there a reason for requiring a user identifier both as a parameter in the post body and as a part of the buystring?
jonasKjellerup
approved these changes
Nov 15, 2022
|
@Zaph-x fails black |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to get us closer to moving away from a monolithic application.
This is done by creating API endpoints, which exposes mostly public facing data in stregsystemet through GET requests.
Furthermore, a sale endpoint which accepts POST requests has been added.