Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize easter-theme & Remove 13:37 Easter egg #329

Merged
merged 12 commits into from
Apr 7, 2024

Conversation

miniJmo
Copy link
Contributor

@miniJmo miniJmo commented Apr 4, 2023

Things changed in the easter theme:

  • Removed cursed easter-egg
  • changed beerflake gifs to webp and CSS for performance gain
  • refactoring

Builds on the #305 pull request

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.45%. Comparing base (af0efd8) to head (eba739d).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #329   +/-   ##
=======================================
  Coverage   53.45%   53.45%           
=======================================
  Files          33       33           
  Lines        4553     4553           
  Branches      267      267           
=======================================
  Hits         2434     2434           
  Misses       2069     2069           
  Partials       50       50           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miniJmo miniJmo changed the title optimised easter theme Optimised easter theme Apr 4, 2023
Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. Needs to catch up with upstream.

stregsystem/static/stregsystem/easter.css Show resolved Hide resolved
stregsystem/static/stregsystem/easter.js Show resolved Hide resolved
@krestenlaust
Copy link
Member

I've merged #305 into next, we need to resolve the merge conflicts in this PR

@krestenlaust
Copy link
Member

@miniJmo should this PR be closed?

@miniJmo
Copy link
Contributor Author

miniJmo commented Mar 6, 2024

@miniJmo should this PR be closed?

@krestenlaust yeah if it is merged, then just close it

@krestenlaust
Copy link
Member

@miniJmo should this PR be closed?

@krestenlaust yeah if it is merged, then just close it

Only #305 has been merged AFAIK

@miniJmo
Copy link
Contributor Author

miniJmo commented Mar 6, 2024

...

Only #305 has been merged AFAIK

well it should be #329 but it also looks like you reverted #305 to then just add it again? anyway if #305 is still in prod, then revert and add #329.

@krestenlaust
Copy link
Member

Nvm, looks like I already reverted the other one in favor of this one. I'll be merging this then

@JakobTopholt
Copy link

Merge when?

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine. I'll just go ahead and rename the PR, then I'll get it merged

@krestenlaust krestenlaust changed the title Optimised easter theme Optimize easter-theme & Remove 13:37 Easter egg Apr 7, 2024
@krestenlaust krestenlaust merged commit 9133300 into f-klubben:next Apr 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants