Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added a random function to randomly distribute news entries #347

Merged
merged 4 commits into from
Sep 3, 2023
Merged

added a random function to randomly distribute news entries #347

merged 4 commits into from
Sep 3, 2023

Conversation

Dev-Destructor
Copy link
Contributor

fixes #346

Copy link
Collaborator

@VirtualSatai VirtualSatai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't pass tests as the empty set, as random.choice([]) is an error

stregsystem/views.py Outdated Show resolved Hide resolved
@Dev-Destructor
Copy link
Contributor Author

Doesn't pass tests as the empty set, as random.choice([]) is an error

Yeah, Sorry

Dev-Destructor and others added 3 commits August 25, 2023 22:50
I have checked your suggestion and tested it in my local environment this time. It works, sorry for random.choice()

Co-authored-by: Falke Carlsen <11318702+falkecarlsen@users.noreply.github.com>
@codecov-commenter
Copy link

Codecov Report

Merging #347 (83a325f) into next (fafb3ac) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head 83a325f differs from pull request most recent head e906af1. Consider uploading reports for the commit e906af1 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             next     #347      +/-   ##
==========================================
- Coverage   80.56%   80.51%   -0.06%     
==========================================
  Files          32       32              
  Lines        2810     2812       +2     
  Branches      217      217              
==========================================
  Hits         2264     2264              
- Misses        511      513       +2     
  Partials       35       35              
Files Changed Coverage Δ
stregsystem/views.py 45.68% <100.00%> (-0.24%) ⬇️

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unnecessary random.choice call on list of one elem.

Thanks :shipit:

@falkecarlsen falkecarlsen merged commit a1b3702 into f-klubben:next Sep 3, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make news to get random entry like kiosk
4 participants