Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set cursor to the F-klub logo #380

Merged
merged 7 commits into from
Nov 1, 2023
Merged

Conversation

Mast3rwaf1z
Copy link
Member

@Mast3rwaf1z Mast3rwaf1z commented Oct 30, 2023

This PR makes the cursor in stregsystemet into the logo for the F-klub.

All changes of the cursor also has a fallback to auto, meaning if anything fails, the cursor will fall back to the default cursor for where it is.

Changes:

  • Added directory stregsystem/static/stregsystem/cursor
  • Added frame{0-14}.png to stregsystem/static/stregsystem/cursor
  • Added file cursor.css to stregsystemet/static/stregsystem, This file has 4 rules:
    • * sets the cursor to stregsystemet/static/stregsystem/cursor/frame14.png
    • input:hover sets the cursor to a rotating logo when hovering over a button or input field
    • @-webkit-keyframes cursor browser compatibility, see below
    • @keyframes cursor defines at how far into the animation each frame should be displayed
  • added cursor.css as file import in stregsystem/templates/stregsystem/base.html

note: i don't care too much whether this gets merged, i'm just familiarizing me with the system

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@5d6d103). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 04df0b8 differs from pull request most recent head e81fd86. Consider uploading reports for the commit e81fd86 to get more accurate results

@@           Coverage Diff           @@
##             next     #380   +/-   ##
=======================================
  Coverage        ?   53.90%           
=======================================
  Files           ?       33           
  Lines           ?     4508           
  Branches        ?      265           
=======================================
  Hits            ?     2430           
  Misses          ?     2028           
  Partials        ?       50           

@falkecarlsen
Copy link
Member

Nice, this is fun. Being pedantic, I think you mean the fstjerne, not the flogo.

Could you post a pic of the cursor on the stregsystem on a 1080p viewport to get a feel for how bad the usability would be?

@Mast3rwaf1z
Copy link
Member Author

Could you post a pic of the cursor on the stregsystem on a 1080p viewport to get a feel for how bad the usability would be?

have a video :)

2023-10-31.13-59-30.mp4

@falkecarlsen
Copy link
Member

It would be interesting to see how hard the stregmaskine is pushed when having to render animated cursor + 30 bats.

@Mast3rwaf1z
Copy link
Member Author

Mast3rwaf1z commented Oct 31, 2023

It would be interesting to see how hard the stregmaskine is pushed when having to render animated cursor + 30 bats.

here, have another video in a slow VM (1024 MB ram, 1 core, no gpu). The server is running on the host system

and its only like 3% more animation anyway :P

Video-23-10-31_5.mp4

Edit: better video too big for github https://www.youtube.com/watch?v=1mQzOYGHKLE

Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Mast3rwaf1z Mast3rwaf1z merged commit 58b2d74 into f-klubben:next Nov 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants