Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enabled file logging handler by default #390

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Enabled file logging handler by default #390

merged 1 commit into from
Nov 6, 2023

Conversation

krestenlaust
Copy link
Member

🤦‍♂️

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2023 •
edited

Codecov Report

Merging #390 (853c8c5) into next (4c9a790) will not change coverage.
The diff coverage is n/a.

❗ Current head 853c8c5 differs from pull request most recent head 2a44a31. Consider uploading reports for the commit 2a44a31 to get more accurate results

@@           Coverage Diff           @@
##             next     #390   +/-   ##
=======================================
  Coverage   53.49%   53.49%           
=======================================
  Files          33       33           
  Lines        4544     4544           
  Branches      267      267           
=======================================
  Hits         2431     2431           
  Misses       2063     2063           
  Partials       50       50
Files Coverage Δ
treo/settings.py 32.62% <ø> (ø)

@krestenlaust
Copy link
Member Author

Picture of the log file being populated

falkecarlsen
falkecarlsen approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@falkecarlsen falkecarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@BoAnd BoAnd self-requested a review November 6, 2023 08:14
@krestenlaust
Copy link
Member Author

#391

@krestenlaust krestenlaust merged commit 049016d into next Nov 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BoAnd BoAnd BoAnd approved these changes

@falkecarlsen falkecarlsen falkecarlsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@krestenlaust @BoAnd @falkecarlsen