[Feature] Step-2 잔여 좌석 조회 API 개발 #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lion
changed the base branch from
develop
to
feat/#59-feature-Residual-seat-domain-design
Base automatically changed from
feat/#59-feature-Residual-seat-domain-design
to
develop
September 18, 2023 11:24
pollra
force-pushed
the
feat/#60-check-remaining-seats-api
branch
from
18c965a
to
e0c6f74
Compare
f-lab-lion
changed the title
pollra
force-pushed
the
feat/#60-check-remaining-seats-api
branch
from
e0c6f74
to
f91314a
Compare
f-lab-lion
reviewed
Sep 23, 2023
| @@ -42,4 +47,12 @@ public Page<ShowMainResponse> getShowListWithPagination( | |||
| .collect(Collectors.toList()); | |||
| return new PageImpl<>(response, pageable, response.size()); | |||
| } | |||
|
|
|||
| @GetMapping("/{showId}/schedule/times/{timeScheduleId}/seats/grades/remaining-counts") | |||
There was a problem hiding this comment.
이 api의 경우 날짜를 누른후, 공연시간 내부에서 등극별 남은좌석수를 조회하는 기능이군요.
그렇다면 아래 화면에서 보여야 되는군요
-
client에서 넣어주어야 하는
timeScheduleId는 어떻게 알 수 있을까요?
바로 직전화면인 montly 정보를 보여주는 화면은/{showId}/schedules을 통해 구성되는데 이때는timeScheduleId를 알 수 없습니다. -
url path는 리소스의 접근을 의미하고
/하나마다 리소스의 계층을 의미한다고 보면 매우 복잡한 구조를 사용한걸로 보입니다.
화면구성에서 유저의 Input은 "날짜의 선택" 이었습니다. 이를 통해 더 간단하게 설계해 볼 수 있을까요?
f-lab-lion
reviewed
Sep 23, 2023
app/src/main/java/com/picketing/www/business/domain/show/seat/grade/SeatGradeFactory.java
Outdated
Show resolved
Hide resolved
f-lab-lion
reviewed
Sep 23, 2023
app/src/main/java/com/picketing/www/business/domain/show/Show.java
Outdated
Show resolved
Hide resolved
yeGenieee
reviewed
Sep 24, 2023
app/src/main/java/com/picketing/www/business/domain/show/seat/grade/Seat.java
Show resolved
Hide resolved
app/src/main/java/com/picketing/www/business/domain/show/seat/grade/SeatGrade.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련된 이슈 번호
변경사항 (할 일)
위 빨간 네모 박스에서 사용하게 될 api 를 개발합니다.
현재는 별다른 제한 사항이 없기 때문에 성능은 깊게 고민하지 않고 개발 할 예정입니다
추가 점검사항
etc
해당 PR 은 #58, #59
이슈에 의존성을 가지고 있습니다#58, #59[Feature] 잔여 좌석 도메인 설계 가 Merge 된 이후 적용 될 예정입니다