Feature/#45 이메일 찾기 #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…u/airjnc into feature/#43_#44_ch-user-log-in-out
Closed
1 task
hoon25
added
Status: Reviewing
Comment on lines
+124
to
+127
| BDDMockito.given(userRepository.selectUserByNameAndPhoneNumber(findEmailRequestDTO.getName(), findEmailRequestDTO.getPhoneNumber())) | ||
| .willReturn(Optional.of(user)); | ||
| // when, then | ||
| assertThat(userServiceImpl.findEmailByNameAndPhoneNumber(findEmailRequestDTO).getEmail()).isEqualTo(UserFixture.EMAIL); |
There was a problem hiding this comment.
given when then 의 역할에 맞게 나누면 이런식으로 테스트 코드를 짜는것이 좋습니다.
//given
given(userRepository.selectByNameAndPhoneNumber(any(), any())).willReturn(Optional.of(user)) ;
//when
User actual = userServiceImpl.findEmailByNameAndPhoneNumber(findEmailRequestDTO);
//then
assertThat(actual.getEmail()).isEqualTo(UserFixture.EMAIL);
then(userRepository).should().selectUserByNameAndPhoneNumber(findEmailRequestDTO.getName(), findEmailRequestDTO.getPhoneNumber());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
To Do List
이름,핸드폰번호를 통해 이메일을 찾을 수 있다.Detail To Do List
Description
이메일 찾기 기능 구현
변경 사항
변경 사항들을 적어주세요
질문 사항
질문 사항들을 적어주세요
기타
그 외로 적고 싶은 내용을 적어주세요
(Optaionl) 어떻게 테스트하셨나요?