[#45] find email #64
Closed
[#45] find email #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 테스트 코드 아직 작성하지 않았습니다. - "이름, 생년월일" 을 통해 유저 아이디 찾기를 진행합니다. - "생년월일"이 아이디 찾기에서 사용되기 때문에, 회원가입시 "생년월일" 데이터를 필수적으로 넘겨야 하는 식으로 변경하였습니다.
memoer
force-pushed
the
feat/#45_jn-find-email
branch
from
fda12c0
to
e600920
Compare
hoon25
reviewed
Aug 3, 2022
| SELECT * | ||
| FROM user | ||
| WHERE email = #{email}; | ||
| </select> |
There was a problem hiding this comment.
select를 할 때 *보다는 컬럼명을 명시해주는 것이 좋을 것 같습니다.
- DB의 메타정보가 변경(컬럼이 추가) 되었을 때, Domain/Entity에 해당 정보가 추가되어있지 않으면 오류가 발생할 수 있습니다.
- Lombok의
@AllArgsConstructor사용을 지양하는 것과 비슷한 느낌
- Lombok의
- findByEmail같은 경우는 사실상 email만 필요합니다.
- email같은 경우는 인덱스를 걸어둘 확률이 높은 컬럼으로 보입니다
- email만 가져온다면 데이터파일을 거치지 않고 인덱스에서 조회가 끝나기 때문에 쿼리조회 성능 또한 오를 것으로 생각됩니다.
There was a problem hiding this comment.
이거는 창훈님꼐서 말씀하신 게 더 최적화가 될 것 같네요!
변경해보도록 하겠습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
[인증] 유저 아이디 찾기 #45
Description