[#45,#46,#56] 테스트 코드 작성 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memoer
force-pushed
the
test/#45,#46,#56
branch
6 times, most recently
from
c7fdbec
to
f7f02c9
Compare
- ExceptionAdvice -> ExceptionController 이름 변경 - `XXXException` 에서 사용하지 않는 메소드들은 제거 - `Errors` 를 생성하는 `ErrorsFactory` 에서 필요한 메소드들 추가
- BCryptHashEncrypter -> HashService 변경
- 코드를 키값으로 레디스에 저장하여 값인 이메일을 가져와 비밀번호를 가져오는 방식이 보안에 취약하다고 생각하였습니다. - 코드를 탈취하면 코드 하나만으로 이메일을 변경할 수 있는 구조에서, 코드와 이메일을 같이 보내어 레디스에 저장되어 있는 코드 값을 확인하는 방식으로 변경하였습니다.
memoer
force-pushed
the
test/#45,#46,#56
branch
from
f7f02c9
to
ccc406a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Description
해당 PR을 하려는 이유를 간단하게 적어주세요
변경 사항
변경 사항들을 적어주세요
질문 사항
질문 사항들을 적어주세요
기타
그 외로 적고 싶은 내용을 적어주세요
(Optaionl) 어떻게 테스트하셨나요?