This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
#14 자바코드 코틀린 전환 #15 코드리뷰 피드백 반영 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 2, 2021 20:58
1. 자바코드 삭제 2. 코틀린으로 재작성 3. 기존 자바코드와 동일하게 동작하는 것 까지 확인
주요 내용
1. 싱글턴(object)로 작성
2. User Validation을 UserEntity로 delegate
-> UserLoginServiceImpl에서 로직 제거
-> UserEntity에 custom setter 추가
-> UserEntity setter 테스트는 어디서 해야 될까?
Closed
Closed
FrancescoJo
approved these changes
May 12, 2021
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14 자바코드 코틀린 전환
#15 코드리뷰 피드백 반영