This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[#30] Owner 테스트 코드 작성 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-dev
approved these changes
Nov 22, 2019
| */ | ||
| @Test | ||
| public void signUp_success() { | ||
| OwnerDTO ownerInfo = OwnerDTO.builder() |
There was a problem hiding this comment.
질문있습니다! 빌더를 적용한 경우 기본 생성자를 생성할 수 없게 변하던데, 이 경우 문제는 없는건가요?
There was a problem hiding this comment.
기본생성자는 없어도 됩니다. 사실 구현의 자유인게 어차피 null을 넣을거라면 기본생성자나 빌더나 역할은 비슷하니까요
yyy9942
approved these changes
Nov 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.