This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
회원가입 및 로그인 기능 추가 #3
base: develop
Are you sure you want to change the base?
회원가입 및 로그인 기능 추가 #3
Changes from 1 commit
fc45a1d
6070ae1
ac098bb
7d7c9e0
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너무 문제를 복잡하게 해결하신 것 같은데 이런 에러메세지를 전달하는 로직을 더 심플하게 짜는법을 알아보시면 좋겠습니다~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로그인 처리는 비즈니스 로직이기 때문에 서비스 부분에서 처리해주었습니다.
또한, 패스워드의 경우 응답 값에 넣어주는 것이 아니라 회원 정보 조회의 경우에만 사용되고, 회원번호를 세션 정보로 전달합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
말씀해주신 피드백 내용 반영했습니다. 감사합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
일반적으로 생성자 주입을 권장하고는 합니다. 이유가 무엇일까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
생성자 주입으로 사용할 경우 주입받을 필드 값을 final로 선언이 가능하고 순환 참조를 방지 할 수 있습니다.
또한, Mockito를 활용한 테스트 코드 작성 시 원하는 구현체를 유연하게 주입 할 수 있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이
Autowired
어노테이션이 꼭 필요한가요?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
스프링에서 자동적으로 지원해주고 있기 때문에 꼭 필요하지 않습니다. 해당 피드백 내용은 코드에 반영했습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 메소드에 많은 요청이 접근하면 엄청난 로그를 생성할 것 같네요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 해당 부분은 삭제했습니다. 감사합니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
만약 디버깅에 꼭 필요하다면 레벨을 낮추는것도 괜찮습니다~