Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test - dummy data maker에 객체 생성시 id 포함, 미포함 옵션 #70

Closed
chanwooo opened this issue Dec 1, 2022 · 0 comments · Fixed by #72
Closed

test - dummy data maker에 객체 생성시 id 포함, 미포함 옵션 #70

chanwooo opened this issue Dec 1, 2022 · 0 comments · Fixed by #72
Assignees
@chanwooo

Comments

@chanwooo
Copy link
Contributor

chanwooo commented Dec 1, 2022

test - dummy data maker에 객체 생성시 id 포함, 미포함 옵션

작업내용
chanwooo added a commit that referenced this issue Dec 1, 2022
@chanwooo
#70-DummyDataMaker with id 추가
bd6a638
@chanwooo chanwooo mentioned this issue Dec 1, 2022
Merged
chanwooo added a commit that referenced this issue Dec 1, 2022
@chanwooo
#70-DummyDataMaker 사용하는부분들 수정
e1f0b6e
@chanwooo chanwooo self-assigned this Dec 1, 2022
chanwooo added a commit that referenced this issue Dec 17, 2022
@chanwooo
Merge branch 'develop' into feature-#70
ac5a787 
# Conflicts:
#	src/main/java/flab/quing/review/ReviewController.java
chanwooo added a commit that referenced this issue Dec 17, 2022
@chanwooo
#70 - DummyDataMaker 수정
eb671b4 
- 객체 생성하는 메서드들 non static으로 변경
- withId를 설정하는부분 생성자, 빌더로 변경
- StoreManager 생성 추가
chanwooo added a commit that referenced this issue Dec 17, 2022
@chanwooo
#70 - 테스트코드 수정
1bb5ec2 
- 변경된 dummyDataMaker에 따라서 객체 생성하고 생성된 객체의 생성메서드 사용
chanwooo added a commit that referenced this issue Dec 19, 2022
@chanwooo
#70 - DummyDataMaker init() 제거
17c3f6e
chanwooo added a commit that referenced this issue Dec 19, 2022
@chanwooo
#70 - id를 상수로 직접 입력한것들 테스트용으로 만든 객체의 id를 이용하도록 변경
9d7065f
chanwooo added a commit that referenced this issue Dec 20, 2022
@chanwooo
Feature #70 - DummyDataMaker 변경 (#72)
477e925 
* #46-reviewService
getlist -> getListByStore, getListByUser 분리

* #46-reviewService
- delete요청한 유저가 review의 소유자인지 확인하는로직 추가

* #46-reviewController 작성

* #70-DummyDataMaker with id 추가

* #70-DummyDataMaker 사용하는부분들 수정

* #70 - DummyDataMaker 수정
- 객체 생성하는 메서드들 non static으로 변경
- withId를 설정하는부분 생성자, 빌더로 변경
- StoreManager 생성 추가

* #70 - 테스트코드 수정
- 변경된 dummyDataMaker에 따라서 객체 생성하고 생성된 객체의 생성메서드 사용

* #70 - DummyDataMaker init() 제거

* #70 - id를 상수로 직접 입력한것들 테스트용으로 만든 객체의 id를 이용하도록 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chanwooo chanwooo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature #70 - DummyDataMaker 변경 f-lab-edu/quing
1 participant
@chanwooo