This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
[#55] 카테고리 서비스 로직 리팩토링 #57
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-dev
reviewed
Apr 12, 2021
| @@ -12,17 +12,11 @@ | |||
|
|
|||
| private final CategoryService categoryService; | |||
|
|
|||
| @PostMapping | |||
| public HttpStatus addMainCategory (@RequestBody String name) { | |||
| @PostMapping(value = {"/", "/{id}"}) | |||
There was a problem hiding this comment.
여기는 2개를 주신 의도가 무엇이실까요? ID는 auto increment로 부여되는 것 아닐까요?
There was a problem hiding this comment.
의도는 메인 카테고리와 서브 카테고리를 추가할 때, 부모 카테고리 id의 존재 여부에 따라 두 개를 분기 시키고자했습니다.
하나의 기능이 하나의 책임을 갖게 하는 것이 유지 보수에 더 유리할 것으로 판단하여 다시 분리했습니다.
추가적으로 한 번에 하나의 카테고리 추가가 아닌 List로 추가할 수 있도록 변경했습니다.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.