This repository has been archived by the owner on Aug 13, 2022. It is now read-only.
#3 그룹 팔로워 신청 기능 개발 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GroupFollowerCreator 기능 개발 카드정보 검증 기능 개발 Group중에 OTT 최대인원보다 적은 그룹 Query 기능 개발 Closes #3
f-lab-tomo
reviewed
Mar 25, 2022
|
|
||
| // TODO:결제진행 은 PG사를 mocking 하고싶다. | ||
|
|
||
| productGroup.setCurrentParticipantsSize(productGroup.getCurrentParticipantsSize() + 1); |
There was a problem hiding this comment.
get/set 으로 진행하기 보다는 "증가" 를 수행하는 역할을 정의해보는게 좋을 것 같아요
f-lab-tomo
reviewed
Mar 25, 2022
| @@ -17,15 +19,31 @@ | |||
| @JoinColumn(name = "ott_product_id", referencedColumnName = "ott_product_id") | |||
| private OttProduct ottProduct; | |||
|
|
|||
| @Getter | |||
| @Setter | |||
| @Column(name = "current_participants_size") | |||
| private Integer currentParticipantsSize; | |||
There was a problem hiding this comment.
current_participants_size 현재 그룹의 몇 명의 인원이 들어가 있는지 나타내는 숫자입니다. :)
There was a problem hiding this comment.
뭔가 참여자 수를 세어 넣을 수 있다면 좋을 것 같은데 지금 구조로는 어렵군요
참여자와 참여자 수를 각각 다루고 있어서 데이터가 꼬이지 않도록 신경을 써야겠어요 ㅎㅎ
f-lab-tomo
approved these changes
Mar 28, 2022
| @@ -0,0 +1,63 @@ | |||
| package me.maru.seeTogether.service.group.accout.groupFollower.create; | |||
There was a problem hiding this comment.
impl 들은 /impl 패키지로 분리해보세요. 구현과 스펙을 구분하기 좋습니다
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GroupFollowerCreator 기능 개발
카드정보 검증 기능 개발
Group중에 OTT 최대인원보다 적은 그룹 Query 개발
Closes #3