Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 리뷰 등록 안되는 현상 #80

Closed
f-lab-lion opened this issue Nov 11, 2022 · 0 comments · Fixed by #91
Closed

[BUG] 리뷰 등록 안되는 현상 #80

f-lab-lion opened this issue Nov 11, 2022 · 0 comments · Fixed by #91
Assignees
Labels
bug Something isn't working feature

Comments

@f-lab-lion
Copy link
Collaborator

f-lab-lion commented Nov 11, 2022

Describe the bug

리뷰등록 api 동작하지않음

To Reproduce

재현하기 위한 스텝을 상세히 기록해 주세요
POST http://localhost:8080/reviews

{
    "userId": 1123,
    "productId": 1,
    "score": 1,
    "content": "일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십일이삼사오륙칠팔구십"
}

etc

2022-11-11 16:40:26.486 ERROR 19830 --- [nio-8080-exec-9] o.a.c.c.C.[.[.[/].[dispatcherServlet] : Servlet.service() for servlet [dispatcherServlet] in context with path [] threw exception [Request processing failed; nested exception is org.springframework.http.converter.HttpMessageConversionException: Type definition error: [simple type, class com.uniqueauction.web.review.request.SaveReviewRequest]; nested exception is com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of com.uniqueauction.web.review.request.SaveReviewRequest (no Creators, like default constructor, exist): cannot deserialize from Object value (no delegate- or property-based Creator)

2번째 이슈

위 이슈가 해결되었다고 가정하더라도 아래 이슈가 발생합니다.
유저가 없는경우 response가 아래처럼 출력됩니다.

{
    "success": false,
    "error": {
        "errorCode": "not_found_user",
        "errorMessage": "가입하지 않은 이메일이거나 잘못된 비밀번호입니다."
    }
}

유저의 id나 password를 입력하지 않았기때문에 적절하지 않습니다.

@f-lab-lion f-lab-lion added bug Something isn't working feature labels Nov 11, 2022
@vymr1000 vymr1000 linked a pull request Nov 18, 2022 that will close this issue
@vymr1000 vymr1000 self-assigned this Nov 18, 2022
superkkj added a commit that referenced this issue Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants