[#18] Feature: Trade 즉시 구매, 판매 구현 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-lab-lion
reviewed
Oct 3, 2022
| .filter(e -> e.getValue().getModelNumber().equals(modelNumber)) | ||
| .filter(e -> e.getValue().getSize().equals(size)).findFirst() | ||
| .map(e -> e.getValue().getId()) | ||
| .orElse(0L); |
There was a problem hiding this comment.
size가 신발이나 의류의 크기를 의미하는것같은데 맞나요?- paging 처리에서 사용하는 size와 혼동이 생길 여지가 있네요.. 더 좋은 이름이 없을까요?
isExists는 보통is를 제외하고 사용합니다.- filter는 두번 사용할 필요는 없습니다. 하나의 필터에 모든조건을 넣으면 반복이 줄어 성능이 좋아집니다.
There was a problem hiding this comment.
이부분도 존재여부만 판단하면 되기때문에
boolean 으로 바꾸고, anyMatch를 사용하면 좋습니다.
anyMatch는 하나라도 찾으면 이후 loop를 돌지 않기때문에 모든 element를 순회하는 fliter보다 성능이 좋을것입니다.
Id값이 정말 필요한것이라면 findByModelNumberAndSize()를 활용하는것이 좋습니다
f-lab-lion
reviewed
Oct 3, 2022
src/main/java/com/uniqueAuction/domain/trade/repository/SaleRepositoryImpl.java
Outdated
Show resolved
Hide resolved
superkkj
approved these changes
Oct 8, 2022
| private Long userId; | ||
| private Long productId; | ||
| private String modelNumber; |
There was a problem hiding this comment.
product ID에서 모델넘버로바뀐이유가뭔지 알수있을까요?
| private Long userId; | ||
| private Long productId; | ||
| private String modelNumber; |
There was a problem hiding this comment.
모델넘버는 기본 키값이 될수 없을거같은데 ProductId가 맞는거 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련된 이슈 번호
요약
변경사항 (할 일)